alveifbklsiu259 commented on code in PR #32333: URL: https://github.com/apache/superset/pull/32333#discussion_r1964137671
########## scripts/eslint.sh: ########## @@ -0,0 +1,25 @@ +#!/usr/bin/env bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e + +script_dir="$(dirname "$(realpath "$0")")" +root_dir="$(dirname "$script_dir")" +frontend_dir=superset-frontend + +cd "$root_dir/$frontend_dir" +npm run eslint -- "${@//$frontend_dir\//}" Review Comment: ```bash if ! npm run eslint -- "${@//$frontend_dir//}"; then echo "Error: ESLint command failed" >&2 exit 1 fi ``` Not adding this because it would still print "Error: ESLint command failed" when eslint runs successfully (but catches error). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
