justinpark commented on code in PR #32284:
URL: https://github.com/apache/superset/pull/32284#discussion_r1960278050
##########
superset/security/manager.py:
##########
@@ -330,6 +330,8 @@ class SupersetSecurityManager( # pylint:
disable=too-many-public-methods
("menu_access", "SQL Editor"),
("menu_access", "Saved Queries"),
("menu_access", "Query Search"),
+ ("can_read", "SqlLabPermalinkRestApi"),
+ ("can_write", "SqlLabPermalinkRestApi"),
Review Comment:
The permalink rest api follows `sqllab` resource
([here](https://github.com/apache/superset/pull/29163/files#diff-c4e8d9dc9eec6a02dbb7e8689350aaa761339f1ef0814ec9cfa0758757f34ebdR40))
so it's unnecessary to add this new role.
Additionally, this is where additional permissions related to view access
are defined, and the permalink does not have a menu either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
