korbit-ai[bot] commented on code in PR #32235:
URL: https://github.com/apache/superset/pull/32235#discussion_r1952872162
##########
superset/migrations/shared/native_filters.py:
##########
@@ -49,7 +48,7 @@
:see: convert_filter_scopes
"""
- shortid = ShortId()
+ short_id = f"{shortid()}"[:9]
Review Comment:
@hainenber While shuffling the truncated UUIDv4 would indeed increase
randomness and lower the chance of collisions, it isn't considered a reliable
strategy. This is due to the fact that the chances of collision still exist and
can potentially cause issues. If maintaining a 9-char limit is crucial, you
could consider using a larger character set (including upper case, lower case,
and numbers) or combination of timestamp and random characters, as previously
suggested. Nevertheless, it's always good to keep in mind that whatever method
used should have collision check or handling mechanism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
