korbit-ai[bot] commented on code in PR #32235:
URL: https://github.com/apache/superset/pull/32235#discussion_r1952842021
##########
superset/migrations/shared/native_filters.py:
##########
@@ -85,7 +84,7 @@ def convert_filter_scopes_to_native_filters( # pylint:
disable=invalid-name,too
fltr: dict[str, Any] = {
"cascadeParentIds": [],
- "id": f"NATIVE_FILTER-{shortid.generate()}",
+ "id": f"NATIVE_FILTER-{short_id}",
Review Comment:
Thanks for the explanation @hainenber!. If it is intentional to reuse the
filterID, then it makes sense to have the ID generation outside the loop.
Appreciate your response, and the work you're doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
