hainenber opened a new pull request, #32235: URL: https://github.com/apache/superset/pull/32235
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> chore(backend): replace insecure `shortid` usage for native filter migration with native `uuid` Python implementation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The Pypi package `shortid` is based on [a deprecated npm module `shortid`](https://github.com/dylang/shortid?tab=readme-ov-file) so a migration is very much anticipated. Luckily, there is a native Python implementation in place already in place so I decided to use it to swap around. Other examples ([1](https://github.com/apache/superset/blob/master/superset-frontend/spec/fixtures/mockNativeFilters.ts#L60), [2](https://github.com/apache/superset/blob/master/tests/integration_tests/migrations/fc3a3a8ff221_migrate_filter_sets_to_new_format__tests.py#L176)) shows that the native filter's generated ID has 9 chars whilst [`shortid()` gives out 12 chars](https://github.com/apache/superset/blob/master/superset/utils/core.py#L1377) so I truncated to 9 chars to ensure status quo. <img width="748" alt="image" src="https://github.com/user-attachments/assets/ce7a4eee-e46a-4c0e-a8b1-0b72d12aaf09"; /> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> N/A ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
