pomegranited commented on code in PR #31751:
URL: https://github.com/apache/superset/pull/31751#discussion_r1933790458
##########
superset-frontend/plugins/plugin-chart-echarts/package.json:
##########
@@ -24,9 +24,11 @@
"lib"
],
"dependencies": {
+ "@types/react-redux": "^7.1.34",
"d3-array": "^1.2.0",
+ "dayjs": "^1.11.13",
"lodash": "^4.17.21",
- "dayjs": "^1.11.13"
+ "superset": "^2.0.1"
Review Comment:
Could you revert these changes? I don't think they're needed.
##########
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx:
##########
@@ -27,8 +27,11 @@ import {
Ref,
} from 'react';
+import { useSelector } from 'react-redux';
+import { ExplorePageState } from 'src/explore/types';
Review Comment:
@jpchev I think the issue is actually here, because it introduces a
dependency between the echart plugin and the superset-frontend code, and so the
typescript compiler (tsc) doesn't know how to deal with it.
You can work around it by removing this import:
```suggestion
```
And defining that interface inline below (under the rest of the imports):
```typescript
// Define this interface here to avoid creating a dependency back to
superset-frontend,
// and to appease the compiler.
// ref: superset-frontend/src/explore/types
interface ExplorePageState {
common: {
locale: string;
};
};
```
##########
superset-frontend/package-lock.json:
##########
@@ -50218,6 +50218,14 @@
"version": "4.2.0",
"license": "MIT"
},
+ "node_modules/superset": {
Review Comment:
Could you revert these changes? I don't think they're needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
