pomegranited commented on code in PR #31751:
URL: https://github.com/apache/superset/pull/31751#discussion_r1934903273
##########
superset-frontend/plugins/plugin-chart-echarts/package.json:
##########
@@ -24,9 +24,10 @@
"lib"
],
"dependencies": {
+ "@types/react-redux": "^7.1.34",
"d3-array": "^1.2.0",
- "lodash": "^4.17.21",
- "dayjs": "^1.11.13"
+ "dayjs": "^1.11.13",
+ "lodash": "^4.17.21"
Review Comment:
Hmm.. this PR actually adds a dependency on `react-redux`, not just its
`@types/react-redux`.. plus, the version pinned here is slightly higher than
the ["@types/react-redux":
"^7.1.10"](https://github.com/apache/superset/blob/master/superset-frontend/package.json#L273C13-L273C24)
used in superset-frontend.
Could you update this change to use `"@types/react-redux": "^7.1.10"`
instead, and also add ["react-redux":
"^7.2.9"](https://github.com/apache/superset/blob/master/superset-frontend/package.json#L187C6-L187C17)?
I think this really only matters for people who are running the echarts
plugin by itself, but would still be good to keep this file correct.
```diff
@@ -27,10 +27,12 @@
"access": "public"
},
"dependencies": {
+ "@types/react-redux": "^7.1.34",
"d3-array": "^1.2.0",
"echarts": "^5.4.1",
"lodash": "^4.17.21",
- "moment": "^2.30.1"
+ "moment": "^2.30.1",
+ "react-redux": "^7.2.9"
},
"peerDependencies": {
"@superset-ui/chart-controls": "*",
```
Steps to achieve this:
```
git checkout master
superset-frontend/plugins/plugin-chart-echarts/package.json
cd superset-frontend
nvm use
npm install "react-redux@^7.2.9" "@types/react-redux@^7.1.10"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
