jpchev commented on PR #31751: URL: https://github.com/apache/superset/pull/31751#issuecomment-2607145322
> @villebro might be most qualified to look at this one, if he has time. That said, there are some failing tests that could use attention, and a more descritive PR title could help too :D sorry for the cryptic title, I've put the title of the issue it fixes. Also, I see one of the check fails because I used the 'require' import https://github.com/apache/superset/actions/runs/12825802735/job/35764682648?pr=31751#step:4:4582 I know it's not recommended, but I don't know how to dynamically import a js file without using 'require'. There is an async alternative, but that would make the code much less clear, in my opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
