mistercrunch commented on code in PR #31796:
URL: https://github.com/apache/superset/pull/31796#discussion_r1911282941


##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -107,6 +108,18 @@ class CeleryConfig:
 log_level_text = os.getenv("SUPERSET_LOG_LEVEL", "INFO")
 LOG_LEVEL = getattr(logging, log_level_text.upper(), logging.INFO)
 
+if os.getenv("CYPRESS_CONFIG") == "true":
+    # When running the service as a cypress backend, we need to import the 
config
+    # located @ tests/integration_tests/superset_test_config.py
+    base_dir = os.path.dirname(__file__)
+    module_folder = os.path.abspath(
+        os.path.join(base_dir, "../../tests/integration_tests/")

Review Comment:
   NOTE: conditionally loading config located at `tests/integration_tests/`, 
but would much rather deprecate that file and merge non-conflicting/duplicated 
configs directly in here. Doing this would need adjustments on CI scripts and 
could break local envs (probably ok as we would instruct devs to work in 
`docker compose`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to