mistercrunch commented on code in PR #31796:
URL: https://github.com/apache/superset/pull/31796#discussion_r1911271053
##########
docker-compose.yml:
##########
@@ -89,6 +89,8 @@ services:
restart: unless-stopped
ports:
- 8088:8088
+ # When in cypress-mode ->
+ - 8081:8081
Review Comment:
NOTE: debated whether to try and open this port conditionally, but seemed
impossible and researched whether there's downside in opening a port-to-nowhere
in other scenarios and I seemed there's no downside. Could also just run
Cypress against 8088 too if we prefer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
