mistercrunch commented on code in PR #31796:
URL: https://github.com/apache/superset/pull/31796#discussion_r1915880771
##########
superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts:
##########
@@ -49,8 +50,10 @@ function confirmDelete() {
function visitChartList() {
interceptFiltering();
+ interceptFavoriteStatus();
cy.visit(CHART_LIST);
cy.wait('@filtering');
+ cy.wait('@favoriteStatus');
Review Comment:
without this `cy.wait` locally (not in CI), during the test assertion the
dom would get re-rendered and I'd get some error about "elements being
disconnected from the dom" or something to that effect.
##########
superset-frontend/cypress-base/cypress/e2e/chart_list/list.test.ts:
##########
@@ -49,8 +50,10 @@ function confirmDelete() {
function visitChartList() {
interceptFiltering();
+ interceptFavoriteStatus();
cy.visit(CHART_LIST);
cy.wait('@filtering');
+ cy.wait('@favoriteStatus');
Review Comment:
NOTE: without this `cy.wait` locally (not in CI), during the test assertion
the dom would get re-rendered and I'd get some error about "elements being
disconnected from the dom" or something to that effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
