lymerin opened a new pull request, #7425: URL: https://github.com/apache/shenyu/pull/7425
Fixes #6516 When a namespace header is present, the registry address rewrite can produce `nnamespace`, discard other query parameters, or truncate addresses containing `namespace` in the host or path. For example, `zookeeper://127.0.0.1:2181?namespace=old` with header `namespace: new` produced `zookeeper://127.0.0.1:2181?nnamespace=new`. Use Dubbo's URL API to replace or append the namespace parameter while preserving the remaining address components and query parameters. Add nine regression cases (eight parameterized cases plus one upstream-path case) covering both reference-building paths and verifying that the original configuration remains unchanged. Validation: all 35 module tests, Checkstyle, and Apache RAT passed with: ```bash ./mvnw -B -pl shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-dubbo/shenyu-plugin-apache-dubbo verify -Djacoco.skip=true -Dmaven.javadoc.skip=true ``` Make sure that: - [x] You have read the [[contribution guidelines](https://shenyu.apache.org/community/contributor-guide)](https://shenyu.apache.org/community/contributor-guide). - [x] You submit test cases (unit or integration tests) that back your changes. - [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true` (module-scoped using `-pl shenyu-plugin/shenyu-plugin-proxy/shenyu-plugin-rpc/shenyu-plugin-dubbo/shenyu-plugin-apache-dubbo`; the full reactor build has not been run). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
