sunnysabor commented on PR #7259: URL: https://github.com/apache/shenyu/pull/7259#issuecomment-5930989908
I made the exhaustion interleaving deterministic in a temporary, uncommitted probe on head `13a65d03fff36d224dcc5df0e52e1e96967160ad`: queue an initial failed payload, run the task through 18 failed retries (each restoring the pending holder), enqueue a second failed payload with the same registration key, then invoke the exhausted run. `./mvnw -B -pl shenyu-register-center/shenyu-register-client/shenyu-register-client-api -Dtest=FailbackRegistryRepositoryTest#probeNewFailureAfterRetryBudgetIsNotRemoved -Djacoco.skip=true -Dmaven.javadoc.skip=true test` passed Checkstyle and failed at the final assertion: expected one pending failure, got zero. I removed the probe after confirming the result. This verifies the race described in my review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
