Aias00 commented on PR #7377: URL: https://github.com/apache/shenyu/pull/7377#issuecomment-5925138031
Status update on my earlier request, since things have moved: #7174 has now been **merged**. That matters here in two ways. 1. **Rebase needed.** `MemorySafeWindowTinyLFUMapTest.java` now carries the changes #7174 merged (it removed the `catch (Throwable)` wrappers that were hiding assertion failures). Your branch deletes that file as it existed before, so it now conflicts with current master — please rebase. 2. **Please confirm the deletion is still wanted.** #7174 deliberately hardened that test so eviction assertion failures would actually fail the build. Deleting the class takes that hardening with it. I'm not saying that's wrong — if `MemorySafeWindowTinyLFUMap` is genuinely unused, removing it and its test together is the cleaner end state — but it should be a conscious decision rather than a side effect, and the RELEASE-NOTES entry should say the type was removed (this is a public `shenyu-common` class, so it's an API removal). Still blocking regardless: **no check run has ever been reported for this head commit** (0 of ~36 jobs). Removing ~190 lines of production code plus its test without a single CI signal is not something I can approve. A rebase should trigger the matrix — once it's green and the point above is confirmed, I'm happy to take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
