Sean-Walker0 commented on PR #7375:
URL: https://github.com/apache/shenyu/pull/7375#issuecomment-5903514701
Addressed all three points from the review:
1. **Blank tokens filtered centrally** in the `KeyWordMatch` constructor —
callers keep passing `keywords.split(";")` unchanged; `name;;token` can no
longer contribute an empty alternative.
2. **All-blank set defined as never-match** — when no valid token remains,
the constructor compiles `(?!)` (an always-failing negative lookahead) instead
of the empty pattern, which previously still matched the empty string. This
also covers the empty set.
3. **Both requested regressions added**:
`matchesShouldIgnoreBlankTokensFromSplitKeywords` (mixed set with an empty
token — failed on the previous commit with `expected: <false> but was: <true>`;
leading-blank variant included) and
`matchesShouldNeverMatchWhenAllTokensAreBlank` (all-blank set matches neither
`""` nor `anything`).
Full module suite + checkstyle green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
