efegokdemir commented on code in PR #671:
URL: https://github.com/apache/shenyu-dashboard/pull/671#discussion_r4111404835
##########
src/routes/Plugin/Discovery/ProxySelectorModal.js:
##########
@@ -113,8 +114,9 @@ class ProxySelectorModal extends Component {
pluginHandles[0] = filteredArray;
this.setState({ pluginHandleList: pluginHandles });
- let defaultValue = handlerArray[0].defaultValue;
- this.setState({ defaultValueList: defaultValue.split(",") });
+ this.setState({
+ defaultValueList: getDefaultValueList(handlerArray[0]),
Review Comment:
Fixed in 96a2b24. The render guard now checks discoveryHandler?.[0] before
dereferencing handler fields, so a plugin handle list without discoveryHandler
safely omits the handler-specific form. Added a component-level regression that
runs the initialization callback with another handle definition present and
verifies the mounted component renders without throwing. Focused tests, ESLint,
Prettier, git diff --check, and npm run build passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
