Aias00 commented on issue #6606: URL: https://github.com/apache/shenyu/issues/6606#issuecomment-5844407945
Current cleanup analysis confirms the delete path is now concrete: - `RegisterExecutionRepository`, `RegisterExecutionLock`, `PlatformTransactionRegisterExecutionRepository`, `ForUpdateBackedRegisterExecutionLock`, and `RegisterTransactionUtil` have no production consumers outside their own configuration/implementation package. - `RegisterCenterConfiguration` still creates the deprecated bean, but no registration service injects it. - The active context-path registration flow already uses Spring Integration `LockRegistry.obtain(...)`. - JDBC and ZooKeeper cluster-master locks are separate active code and are out of scope. Suggested implementation scope: - delete the five deprecated lock classes; - remove the unused `registerExecutionRepository` bean and related imports; - delete the two dedicated old-lock tests; - retain and regression-test `JdbcLockRegistry`, `ZookeeperLockRegistry`, and context-path registration concurrency. Acceptance criteria: - [ ] No `RegisterExecutionRepository` or `RegisterExecutionLock` reference remains. - [ ] Registration concurrency is still protected through `LockRegistry`. - [ ] JDBC/ZooKeeper cluster election behavior is unchanged. - [ ] Admin unit tests, Checkstyle, and RAT pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
