dengliming opened a new issue, #628: URL: https://github.com/apache/shenyu-dashboard/issues/628
## Description `updateSelector` destructures `discoveryType` from `this.props`, but neither the `discovery` nor the `global` model state has such a key, so `discovery/update` is sent with `discovery.discoveryType: undefined`. The `isSetConfig` check compares `data.type !== "local"`, where `data.type` is the plugin name (`tcp`); the intended value is `data.discovery.type`. ## Location (Lines refer to `master @ 83969a5`.) - `src/routes/Plugin/Discovery/index.js:386-402` (destructure and comparison) - `src/routes/Plugin/Discovery/index.js:425` (correct usage `data.discovery.type` exists a few lines later) ## Impact Updating a TCP selector sends an undefined discovery type, and the "needs config" flag is computed from the wrong field, so local discoveries with a null server list are treated as remote. ## Suggested fix Use `data.discovery.type` for both the payload and the comparison; remove `discoveryType` from the props destructuring. ## Related existing None -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
