dengliming commented on issue #628: URL: https://github.com/apache/shenyu-dashboard/issues/628#issuecomment-5846438792
Rechecked against Dashboard `fed203e` and ShenYu Admin `31e0c3e. The frontend observations are real, but the claimed user-visible failure does not follow from the current frontend/backend contract: - The modal receives `data.discovery.type` and initializes `chosenType` from it. Its local/remote rendering is controlled by `chosenType`, so a local discovery is not turned into a remote form by the incorrect `isSetConfig` comparison. - The update service loads the existing discovery from the relation, updates server list/properties, and retains its stored discovery type. It does not use the omitted nested `discoveryType` to choose a replacement type. The nested DTO field has a constraint, but the parent discovery property does not enable cascaded validation with `@Valid` in this version. The wrong field comparisons are cleanup candidates, but the described broken update/local-as-remote behavior is not established. Closing this bug as not planned rather than requesting a functional fix based on that claim. It can be reopened with a reproduction showing an actual affected operation. Evidence: - [src/routes/Plugin/Discovery/index.js](https://github.com/apache/shenyu-dashboard/blob/fed203e01101c81c73af0a66a79bcb0ee90da73f/src/routes/Plugin/Discovery/index.js#L425) - [src/routes/Plugin/Discovery/ProxySelectorModal.js](https://github.com/apache/shenyu-dashboard/blob/fed203e01101c81c73af0a66a79bcb0ee90da73f/src/routes/Plugin/Discovery/ProxySelectorModal.js#L556) - [shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/ProxySelectorServiceImpl.java](https://github.com/apache/shenyu/blob/31e0c3e34a71436f091dbbd00f181b65de896666/shenyu-admin/src/main/java/org/apache/shenyu/admin/service/impl/ProxySelectorServiceImpl.java#L348) - [shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ProxySelectorAddDTO.java](https://github.com/apache/shenyu/blob/31e0c3e34a71436f091dbbd00f181b65de896666/shenyu-admin/src/main/java/org/apache/shenyu/admin/model/dto/ProxySelectorAddDTO.java#L87) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
