sunnysabor opened a new pull request, #6968: URL: https://github.com/apache/shenyu/pull/6968
Fixes #6967 ### Description Discovery registry implementations such as Eureka and Nacos already read the `props` entry from instance metadata and store it in `DiscoveryUpstreamData.props`. When the divide plugin converts `DiscoveryUpstreamData` to runtime `Upstream`, it only reads built-in properties such as `warmup`, `gray`, and `healthCheckEnabled`. Other custom properties are not preserved in the runtime upstream object. This change preserves parsed discovery upstream `props` as `Upstream.metadata` during divide upstream conversion. It keeps the existing `props` extension channel and does not introduce full registry metadata passthrough. ### Changed Behavior - Existing parsing for `warmup`, `gray`, and `healthCheckEnabled` remains unchanged. - Parsed discovery upstream `props` are also copied into `Upstream.metadata`. - Custom load balancers can read extension properties such as `az`, `version`, or `grayTag` from `Upstream.getMetadata()` when these properties are provided inside discovery upstream `props`. ### Validation - [x] `git diff --check` - [x] `mvn -pl :shenyu-plugin-divide -am -Dtest=DivideUpstreamDataHandlerTest -DfailIfNoTests=false test` - [x] `mvn -pl :shenyu-plugin-divide -am -DfailIfNoTests=false test` - [ ] `./mvnw clean install -Dmaven.javadoc.skip=true` was not run locally. ### Checklist - [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide). - [x] You submit test cases (unit or integration tests) that back your changes. - [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
