Aias00 opened a new issue, #6887:
URL: https://github.com/apache/shenyu/issues/6887

   ## Description
   `createParameterSchema` and `recursionConstructPropertiesNodes` set only 
`type`/`description`/`properties`/`items`. The `required` array is never 
written, and `McpServerToolParameter.required`/`defaultValue` fields are 
ignored. Per JSON Schema / MCP, required parameters must be listed in a 
top-level `required` array.
   
   ## Location
   - 
`shenyu-plugin/shenyu-plugin-mcp-server/src/main/java/org/apache/shenyu/plugin/mcp/server/utils/JsonSchemaUtil.java:49-67`
   
   ## Impact
   MCP clients treat every parameter as optional and won't enforce/validate the 
tool's real contract; tools silently accept calls missing required arguments.
   
   ## Suggested fix
   Collect parameters where `parameter.isRequired()` is true into a `required` 
ArrayNode on the schema root.
   
   ## Related existing
   None.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to