moremind commented on code in PR #6336:
URL: https://github.com/apache/shenyu/pull/6336#discussion_r3253003345
##########
shenyu-plugin/shenyu-plugin-base/src/main/java/org/apache/shenyu/plugin/base/AbstractShenyuPlugin.java:
##########
@@ -57,9 +61,9 @@ public abstract class AbstractShenyuPlugin implements
ShenyuPlugin {
private static final String URI_CONDITION_TYPE = "uri";
- private ShenyuConfig.SelectorMatchCache selectorMatchConfig;
-
- private ShenyuConfig.RuleMatchCache ruleMatchConfig;
+ private volatile ShenyuConfig.SelectorMatchCache selectorMatchConfig;
+
+ private volatile ShenyuConfig.RuleMatchCache ruleMatchConfig;
Review Comment:
why add volatile? just readable value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
