matthiasblaesing commented on PR #9310: URL: https://github.com/apache/netbeans/pull/9310#issuecomment-4193282739
Thank you for the update. From the code perspective this looks sane to me. I'm in the region of nitpicking. The commit message should describe why a change was done (and if huge give a summary of the changes). A quick idea: ``` Netigso: Fix parsing of complex Export-Package manifest entries Export-Package entries are not just comma separated values, but can contain parameters, which themselves can contain commas in quoted strings. These cases need to be handled correctly. ``` This is a suggestion, feel free to rephrase of course. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
