matthiasblaesing commented on PR #9310: URL: https://github.com/apache/netbeans/pull/9310#issuecomment-4188424240
In general this looks sane to me. Specially thanks for the added test. Please check the author information though the "Paperwork" check ensures that author information is valid and the assumption, that a real name consists of at least two parts that are separated by a space. Have a look at https://github.com/apache/netbeans/pull/9310.patch (or your preferred git client that shows real author information), line "From: ". I'm aware that there are countries/regions where a single name is common and if that is the case, no problem, if that does not apply to you, please adjust the author information. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
