YannLeCorse commented on code in PR #9310:
URL: https://github.com/apache/netbeans/pull/9310#discussion_r3014091639
##########
platform/core.netigso/src/org/netbeans/core/netigso/Netigso.java:
##########
@@ -291,7 +291,8 @@ protected Set<String> createLoader(ModuleInfo m,
ProxyClassLoader pcl, File jar)
}
}
if (exported instanceof String) {
- for (String p : exported.toString().split(",")) { //
NOI18N
+ String regexp = ",(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)";
// NOI18N
Review Comment:
Hi Matthias,
The intention was to catch pair of quote with minimal changes but you're
right, it's heavy and incorrect too as I missed the `\"` cases. I'll apply your
recommendations asap.
Thanks for your time on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
