mbien commented on code in PR #9303:
URL: https://github.com/apache/netbeans/pull/9303#discussion_r3005110755
##########
platform/core.startup/src/org/netbeans/core/startup/Splash.java:
##########
@@ -156,26 +176,40 @@ public void setRunning(boolean running) {
return;
}
+ Runnable edtAction;
if (running) {
- if (frame == null) {
- frame = new Frame(NbBundle.getMessage(Splash.class,
"LBL_splash_window_title")); // e.g. for window tray display
- //#215320
- frame.setType(Window.Type.POPUP);
Review Comment:
> I assume by "no longer modal" you mean the window type?
yes its the window type. It used to be set to POPUP.
> What changes does that introduce across OS?
- X11: if you use window effects, they would be more likely to apply to the
splash now. (e.g window popup animation or shadow)
- wayland: well. window positioning is not implemented still, applications
tend to give up on splash screens and simply not render them since they would
pop up on a random spot on the screen
- on tiling WMs: i have no clue, might look funny. Simply start with
`--nosplash` if there is a problem i guess.
- win 11: it appears to work fine
- mac: I don't know
> Curious why it was felt necessary originally?
not sure. But back in the days it was more common to see modal splash
screens. While the system was busy opening something, you wouldn't be able to
use it anyway. Today, systems are usually under utilized even on application
starts due to vastly improved hardware capabilities (NVMe, multicore etc).
Perceived performance was improved by making splashes pop up as fast as
possible so that it looked fast - today this is not really a concern I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
