neilcsmith-net commented on PR #9303:
URL: https://github.com/apache/netbeans/pull/9303#issuecomment-4147869930

   +1 to moving the Swing initialization into the right place.
   
   From what I recall, the JVM `--splash` feature is never used any more and 
has been disabled since #1246 
   
   Since that PR we really should have some code in `Splash` to set the 
`WM_CLASS` on it.  The code at 
https://github.com/apache/netbeans/blob/master/platform/core.windows/src/org/netbeans/core/windows/view/ui/MainWindow.java#L127
 comes too late.  We have a workaround in the NetBeans installer builds to work 
around this with the desktop file name, but it's not ideal.  I did look at this 
once, but getting the right value is difficult - maybe just need a different 
branding token for it.  Not saying you have to look at that in the context of 
this PR either!  Just making a note.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Reply via email to