neilcsmith-net commented on PR #9303: URL: https://github.com/apache/netbeans/pull/9303#issuecomment-4153864044
> On the USE_LAUNCHER_SPLASH = false thing: I could not get this working with HiDPI on Windows in the past. It's also quite a lot of complexity spent on getting the splash screen to show just a tiny bit earlier in the startup cycle. Well, it also has the benefit of not having `WM_CLASS` set on it. But I remember the discussion around the issues. I know you can change the image via the API after it's shown, but that's probably not a useful workaround .. > On WM_CLASS: It's good to have this set properly, yes! Is your concern that it is not being set on the splash screen frame, only on the eventual main window? The problem is not that it isn't set, but that it's set to the default. If you start up the toolkit in the main thread, you'll get the name of the main class, but off another thread like we are, the splash gets `WM_CLASS` set to `java-lang-Thread`. See https://github.com/openjdk/jdk/blob/master/src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java#L393 This started being a problem when we stopped using the JDK splash. And why we get duplicate icons in Linux docks if relying solely on matching against `WM_CLASS`. Of course, we could match `Java-lang-Thread` but then other Java apps start getting the NetBeans icon. At least GNOME also does some text matching on the name of the desktop file. This is why NBPackage has the ability to customise the desktop file name as well as the desktop wm_class match. It's unknown which Linux desktops this actually works correctly on! See also https://github.com/codelerity/netbeans-packages/blob/main/config/linux-x64-deb.properties#L20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
