ppkarwasz commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2041061619
##########
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##########
@@ -49,25 +55,15 @@
"key": "span_id"
},
"logging.googleapis.com/trace_sampled": true,
- "_exception": {
- "class": {
- "$resolver": "exception",
- "field": "className"
- },
- "message": {
- "$resolver": "exception",
- "field": "message"
- },
- "stackTrace": {
- "$resolver": "pattern",
- "pattern": "%xEx"
- }
+ "exception": {
+ "$resolver": "pattern",
+ "pattern": "%xEx"
},
Review Comment:
> I also tried to use `exception` resolver but it produces just a stack
trace without header and is not cought by Google Error Reporting. So in the end
I left `pattern` resolver like it was originally.
That is interesting, the snippet above produces **exactly** the same output
as `Throwable.printStackTrace()`. @vy, any ideas?
My preferences for these field are in order:
1. `exception` resolver if it works.
2. `pattern` with a pattern of `%ex` (less computationally intensive)
3. what is currently proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
