vy commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2046330472


##########
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##########
@@ -37,8 +42,9 @@
     }
   },
   "logging.googleapis.com/insertId": {
-    "$resolver": "counter",
-    "stringified": true
+    "$resolver": "pattern",
+    "pattern": "%uuid{TIME}",
+    "stackTraceEnabled": false

Review Comment:
   @ViliusS, I have the inkling that those messages containing overlapping 
`insertId`'s are not originating from the same host. But all in all, indeed _"a 
counter unique per JTL instance"_ does not guarantee the uniqueness required by 
`insertId`. We are better off just omitting that field and letting it be 
auto-generated by GCP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to