pan3793 commented on code in PR #7370:
URL: https://github.com/apache/kyuubi/pull/7370#discussion_r3006201866


##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/KyuubiHiveConnectorConf.scala:
##########
@@ -57,4 +57,12 @@ object KyuubiHiveConnectorConf {
       .version("1.11.0")
       .booleanConf
       .createWithDefault(true)
+
+  val DROP_TABLE_WITH_PURGE =
+    buildConf("spark.sql.kyuubi.hive.connector.dropTableWithPurge")
+      .doc("When enabled, the DROP TABLE command will completely remove its 
data " +
+        "by skipping trash, equivalent to the PURGE TABLE command.")
+      .version("1.12.0")
+      .booleanConf
+      .createWithDefault(false)

Review Comment:
   I checked on the Spark side, it seems that after SPARK-43203 (3.5.0), `DROP 
TABLE hive_table [PURGE]` moves to V2 commands, and respects `PURGE` flag, 
previously, it always performed as `purge=true`, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to