pan3793 commented on code in PR #7370:
URL: https://github.com/apache/kyuubi/pull/7370#discussion_r2999826170
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTableCatalog.scala:
##########
@@ -392,6 +392,8 @@ class HiveTableCatalog(sparkSession: SparkSession)
loadTable(ident)
}
+ override def purgeTable(ident: Identifier): Boolean = dropTable(ident)
Review Comment:
IIRC, the purge has some effect actually, the `purge` flag will be passed to
the HMS request
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTableCatalog.scala:
##########
@@ -392,6 +392,8 @@ class HiveTableCatalog(sparkSession: SparkSession)
loadTable(ident)
}
+ override def purgeTable(ident: Identifier): Boolean = dropTable(ident)
Review Comment:
IIRC, the purge flag has some effect actually, the `purge` flag will be
passed to the HMS request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
