pan3793 commented on code in PR #7370:
URL: https://github.com/apache/kyuubi/pull/7370#discussion_r3000064600
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/HiveTableCatalog.scala:
##########
@@ -392,6 +392,8 @@ class HiveTableCatalog(sparkSession: SparkSession)
loadTable(ident)
}
+ override def purgeTable(ident: Identifier): Boolean = dropTable(ident)
Review Comment:
according to the API semantic, dropTable means `purge=false`, right? given
the existing behavior already violates that, we may need a config to control
the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
