arnt commented on code in PR #3130:
URL: https://github.com/apache/james-project/pull/3130#discussion_r3959466388
##########
mdn/src/main/java/org/apache/james/mdn/MDN.java:
##########
@@ -193,6 +193,19 @@ public static Optional<MDNReport>
extractMDNReport(List<Entity> entities) {
});
}
+ /**
+ * RFC 6533 defines {@code message/global-disposition-notification} as
UTF-8;
+ * no charset parameter is defined for it, so senders legitimately omit
one and
+ * mime4j then falls back to us-ascii. Only the RFC 3798 form honours the
+ * declared charset.
+ */
+ private static String reportCharset(Entity entity) {
Review Comment:
Yes.
I think my brain has found an opinion: at this point it's best to always
follow RFC 6533 when generating, and mostly when parsing (unless that's too
complicated and requires too much code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
