arnt commented on code in PR #3130:
URL: https://github.com/apache/james-project/pull/3130#discussion_r3959294942
##########
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remote/delivery/MailDelivrerToHost.java:
##########
@@ -127,6 +127,20 @@ public ExecutionResult tryDeliveryToHost(Mail mail,
Collection<InternetAddress>
// "mail.smtp.dsn.ret" //default to nothing... appended as RET=
after MAIL FROM line.
// "mail.smtp.dsn.notify" //default to nothing... appended as
NOTIFY= after RCPT TO line.
+ // Angus reads mail.mime.allowutf8 in the SMTPTransport constructor,
so it
+ // has to be decided here -- before the transport exists, hence before
we
+ // can know whether the remote advertises SMTPUTF8. The envelope alone
+ // tells us whether UTF-8 could ever be needed, and that is enough:
Angus
+ // only emits the SMTPUTF8 keyword on MAIL FROM when the remote also
+ // advertises it, and SmtpUtf8Strategy below still decides the
downgrade.
+ // Left alone for the ASCII envelopes that make up the bulk of the
+ // traffic, so they neither change behaviour nor trip Angus' "allowutf8
+ // set but server doesn't advertise SMTPUTF8" log line. The pool clears
+ // the property again when the session is passivated.
Review Comment:
Good point.
Looking at all this, I wonder why the tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
