arnt commented on code in PR #3130:
URL: https://github.com/apache/james-project/pull/3130#discussion_r3958948047
##########
mdn/src/main/java/org/apache/james/mdn/MDN.java:
##########
@@ -193,6 +193,19 @@ public static Optional<MDNReport>
extractMDNReport(List<Entity> entities) {
});
}
+ /**
+ * RFC 6533 defines {@code message/global-disposition-notification} as
UTF-8;
+ * no charset parameter is defined for it, so senders legitimately omit
one and
+ * mime4j then falls back to us-ascii. Only the RFC 3798 form honours the
+ * declared charset.
+ */
+ private static String reportCharset(Entity entity) {
Review Comment:
Just a comment. The code is correct, I think.
There a chance that an RFC will appear sometime in 2027/8 that deprecates
message/global and says to use message/rfc822 for everything. Ditto
text/globalheaders or whatever it was.
I think *generating* message/global is good, for now, but on the *parse*
side I might lean towards accepting UTF8 in message/rfc822 already. Not 100%
sure. I might be strict there too, it depends on the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
