sonatype-lift[bot] commented on code in PR #1747:
URL: https://github.com/apache/groovy/pull/1747#discussion_r922570332
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -535,24 +561,24 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
assert a.x == "3"
}
testBody()
- '''
+ '''
}
void testCallSetterAsPropertyWithinFinallyBlockShouldNotThrowVerifyError()
{
try {
assertScript '''
- class Multi {
- void setOut(int a) {}
- }
+ class Multi {
+ void setOut(int a) {}
+ }
- void foo() {
- def m = new Multi()
- try {
- } finally {
- m.out = 1
- }
- }
- foo()
+ void foo() {
+ def m = new Multi()
+ try {
+ } finally {
+ m.out = 1
+ }
+ }
+ foo()
'''
} finally {
assert astTrees.values().any {
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936539&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936539&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936539&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936539&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936539&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936549&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936549&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936549&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936549&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936549&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
+ assert !dump.contains('pfaccess$00') // no mutator bridge method
for 'accessed'
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936550&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936550&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936550&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936550&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936550&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
+ assert !dump.contains('pfaccess$00') // no mutator bridge method
for 'accessed'
+ assert dump.contains('pfaccess$01') // mutator bridge method for
'mutated'
+ assert dump.contains('pfaccess$1') // accessor bridge method for
'mutated' -- GROOVY-9385
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936552&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936552&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936552&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936552&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936552&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
+ assert !dump.contains('pfaccess$00') // no mutator bridge method
for 'accessed'
+ assert dump.contains('pfaccess$01') // mutator bridge method for
'mutated'
+ assert dump.contains('pfaccess$1') // accessor bridge method for
'mutated' -- GROOVY-9385
+ assert dump.contains('pfaccess$2') // accessor bridge method for
'accessedAndMutated'
+ assert dump.contains('pfaccess$02') // mutator bridge method for
'accessedAndMutated'
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936554&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936554&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936554&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936554&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936554&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
+ assert !dump.contains('pfaccess$00') // no mutator bridge method
for 'accessed'
+ assert dump.contains('pfaccess$01') // mutator bridge method for
'mutated'
+ assert dump.contains('pfaccess$1') // accessor bridge method for
'mutated' -- GROOVY-9385
+ assert dump.contains('pfaccess$2') // accessor bridge method for
'accessedAndMutated'
+ assert dump.contains('pfaccess$02') // mutator bridge method for
'accessedAndMutated'
+ dump = astTrees['A$_closure1'][1]
+ assert dump.contains('INVOKESTATIC A.pfaccess$2
(LA;)Ljava/lang/String;')
+ assert dump.contains('INVOKESTATIC A.pfaccess$02
(LA;Ljava/lang/String;)Ljava/lang/String;')
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936556&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936556&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936556&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936556&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936556&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
+ assert !dump.contains('pfaccess$00') // no mutator bridge method
for 'accessed'
+ assert dump.contains('pfaccess$01') // mutator bridge method for
'mutated'
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936551&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936551&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936551&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936551&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936551&lift_comment_rating=5)
]
##########
src/test/org/codehaus/groovy/classgen/asm/sc/FieldsAndPropertiesStaticCompileTest.groovy:
##########
@@ -759,33 +815,34 @@ import
org.codehaus.groovy.transform.sc.ListOfExpressionsExpression
new A().test()
'''
} finally {
- assert !astTrees['A'][1].contains('pfaccess$00') // no mutator
bridge method for 'accessed'
- assert !astTrees['A'][1].contains('pfaccess$1') // no accessor
bridge method for 'mutated'
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$2 (LA;)Ljava/lang/String;')
- assert astTrees['A$_closure1'][1].contains('INVOKESTATIC
A.pfaccess$02 (LA;Ljava/lang/String;)Ljava/lang/String;')
+ def dump = astTrees['A'][1]
+ assert dump.contains('pfaccess$0') // accessor bridge method for
'accessed'
+ assert !dump.contains('pfaccess$00') // no mutator bridge method
for 'accessed'
+ assert dump.contains('pfaccess$01') // mutator bridge method for
'mutated'
+ assert dump.contains('pfaccess$1') // accessor bridge method for
'mutated' -- GROOVY-9385
+ assert dump.contains('pfaccess$2') // accessor bridge method for
'accessedAndMutated'
Review Comment:
*AssertWithinFinallyBlock:* A finally block within class
org.codehaus.groovy.classgen.asm.sc.FieldsAndPropertiesStaticCompileTest
contains an assert statement, potentially hiding the original exception, if
there is one
Reply with *"**@sonatype-lift help**"* for info about LiftBot commands.
Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the
above finding from this PR.
Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all
the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to **refresh** the page to see its
response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get
to know more about LiftBot commands.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=298936553&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=298936553&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936553&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=298936553&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=298936553&lift_comment_rating=5)
]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
