sonatype-lift[bot] commented on code in PR #1747: URL: https://github.com/apache/groovy/pull/1747#discussion_r922569792
########## src/test-resources/groovy/bugs/groovy9236/Main.groovy: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package groovy.bugs.groovy9236 + +class Outer { + static class Groovy9236 {} Review Comment: *EmptyClass:* Class 'Outer$Groovy9236' is empty (has no methods, fields or properties). Why would you need a class like this? Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=298936238&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=298936238&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936238&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936238&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=298936238&lift_comment_rating=5) ] ########## src/test/gls/generics/GenericsUsageTest.groovy: ########## @@ -408,4 +447,43 @@ final class GenericsUsageTest extends CompilableTestSupport { 'The type String is not a valid substitute for the bounded parameter <T extends java.lang.Number>' ] } + + //-------------------------------------------------------------------------- + + private void shouldFailCompilationWithDefaultMessage(scriptText) { + shouldFailCompilationWithMessage scriptText, "Missing closing bracket '>' for generics types" + } + + private void shouldFailCompilationWithMessage(scriptText, String errorMessage) { + shouldFailCompilationWithMessages(scriptText, [errorMessage]) + } + + private void shouldFailCompilationWithMessages(scriptText, List<String> errorMessages) { + try { + assertScript scriptText + fail("The script compilation should have failed as it contains generics errors, e.g. mis-matching generic brackets") + } catch (MultipleCompilationErrorsException mcee) { + def text = mcee.toString() + errorMessages.each { + assert text.contains(it) + } + } + } + + private void shouldFailCompilationWithAnyMessage(scriptText, List<String> errorMessages) { + try { + assertScript scriptText + fail("The script compilation should have failed as it contains generics errors, e.g. mis-matching generic brackets") + } catch (MultipleCompilationErrorsException mcee) { + def text = mcee.toString() + + for (errorMessage in errorMessages) { + if (text.contains(errorMessage)) { + return + } + } + + assert false, text + " can not match any expected error message: " + errorMessages Review Comment: *ConstantAssertExpression:* The assert statement within class gls.generics.GenericsUsageTest has a constant boolean expression [false] Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=298936246&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=298936246&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936246&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936246&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=298936246&lift_comment_rating=5) ] ########## src/test-resources/groovy/bugs/groovy9236/Groovy9236SamePkg.groovy: ########## @@ -0,0 +1,23 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package groovy.bugs.groovy9236 + +class Groovy9236SamePkg { Review Comment: *EmptyClass:* Class 'Groovy9236SamePkg' is empty (has no methods, fields or properties). Why would you need a class like this? Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=298936237&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=298936237&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936237&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936237&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=298936237&lift_comment_rating=5) ] ########## src/test/gls/innerClass/InnerClassTest.groovy: ########## @@ -1082,15 +1983,3 @@ class Parent8914 { class Outer8914 { Review Comment: *EmptyClass:* Class 'Outer8914' is empty (has no methods, fields or properties). Why would you need a class like this? Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=298936249&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=298936249&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936249&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936249&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=298936249&lift_comment_rating=5) ] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
