sonatype-lift[bot] commented on code in PR #1747: URL: https://github.com/apache/groovy/pull/1747#discussion_r922570072
########## src/test/groovy/bugs/Groovy9589.groovy: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package groovy.bugs + +import org.apache.groovy.parser.antlr4.TestUtils +import org.codehaus.groovy.ast.ModuleNode +import org.codehaus.groovy.control.CompilationUnit +import org.codehaus.groovy.control.CompilerConfiguration +import org.codehaus.groovy.control.Phases +import org.junit.Test + +final class Groovy9589 { + @Test + void testParallelParse() { + final cnt = 2 + def sources = (1..cnt).inject([:]) { r, e -> r["hello${e}.groovy"] = source(e); r } + def ast1 = parse(sources, false) + def ast2 = parse(sources, true) + + assert cnt == ast1.modules.size() + assert ast1.modules.size() == ast2.modules.size() + + out: + for (ModuleNode m1 in ast1.modules) { + for (ModuleNode m2 in ast2.modules) { + if (TestUtils.compareAST(m1, m2)) continue out + } + + assert false Review Comment: *ConstantAssertExpression:* The assert statement within class groovy.bugs.Groovy9589 has a constant boolean expression [false] Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=298936422&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=298936422&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936422&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936422&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=298936422&lift_comment_rating=5) ] ########## src/test/groovy/bugs/Groovy675_Bug.groovy: ########## @@ -18,6 +18,8 @@ */ package groovy.bugs +import groovy.test.GroovyTestCase + class Groovy675_Bug extends GroovyTestCase { void testStringAndGString() { assert "\\"!="\\\\" Review Comment: *ComparisonOfTwoConstants:* Comparing two constants or constant literals is useless and may indicate a bug: (\ != \\) Reply with *"**@sonatype-lift help**"* for info about LiftBot commands. Reply with *"**@sonatype-lift ignore**"* to tell LiftBot to leave out the above finding from this PR. Reply with *"**@sonatype-lift ignoreall**"* to tell LiftBot to leave out all the findings from this PR and from the status bar in Github. When talking to LiftBot, you need to **refresh** the page to see its response. [Click here](https://help.sonatype.com/lift/talking-to-lift) to get to know more about LiftBot commands. --- Was this a good recommendation? [ [🙁 Not relevant](https://www.sonatype.com/lift-comment-rating?comment=298936421&lift_comment_rating=1) ] - [ [😕 Won't fix](https://www.sonatype.com/lift-comment-rating?comment=298936421&lift_comment_rating=2) ] - [ [😑 Not critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936421&lift_comment_rating=3) ] - [ [🙂 Critical, will fix](https://www.sonatype.com/lift-comment-rating?comment=298936421&lift_comment_rating=4) ] - [ [😊 Critical, fixing now](https://www.sonatype.com/lift-comment-rating?comment=298936421&lift_comment_rating=5) ] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
