On Wed, Feb 17, 2016 at 5:49 PM, Or Gerlitz <gerlitz...@gmail.com> wrote:
> On Wed, Feb 17, 2016 at 2:07 PM, Saeed Mahameed
> <sae...@dev.mellanox.co.il> wrote:
>> On Tue, Feb 16, 2016 at 11:38 PM, Or Gerlitz <gerlitz...@gmail.com> wrote:
>
>>>> - for (tc = 0; tc < priv->params.num_tc; tc++) {
>>>> + for (tc = 0; tc < MLX5E_MAX_NUM_TC; tc++) {
>>>> err = mlx5e_create_tis(priv, tc);
>
>>> various places in the patch use priv->params.num_tc, wasn't sure if
>>> it's correct to hard code things here, and if it does, why not hard
>>> code everywhere
>
>> TISs and TIRs unlike SQs and RQs are created once on driver load, so
>> we create the MAX supported TISs (TIS per prio) and when you create
>> the rings/channels (SQs) we create them according to the dynamic
>> "priv->params.num_tc" and then we assign the pre allocated TIS to the
>> SQ according to SQ TC/Prio configuration.
>
> makes sense. Maybe spare few words on that in the change-log, or with
> a small comment
> in the code?
will add to change log.
