On Wed, Feb 17, 2016 at 2:00 PM, Saeed Mahameed
<sae...@dev.mellanox.co.il> wrote:
>>>  struct mlx5e_priv {
>>>         /* priv data path fields - start */
>>> -       int                        default_vlan_prio;
>>>         struct mlx5e_sq            **txq_to_sq_map;
>>>         int channeltc_to_txq_map[MLX5E_MAX_NUM_CHANNELS][MLX5E_MAX_NUM_TC];
>>>         /* priv data path fields - end */
>>
>>
>> Didn't see a note on the removal of the default vlan prio in the
>> change-log, could you elaborate what was the role of it before the
>> patch and why we can just throw it?
>>
> it did nothing other than holding the number "0" which is always the
> default prio for vlans
> it was replaced with a the real 0 (the hardcoded "0") in the following lines:

okay, I would spare a sentence on that removal in the change, just in
case someone lands
here in future bisections and wonders why we removed this.

>> we're happily in 2016 (please fix here and also in other patches that
>> introduce new files)

> Ok.

cool

Reply via email to