On Mon, 7 Jan 2008, David Miller wrote:
> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Tue, 8 Jan 2008 06:00:07 +0100
>
> > On Mon, Jan 07, 2008 at 07:37:00PM -0800, David Miller wrote:
> > > The vast majority of them are one, two, and three liners.
> >
> > % awk ' { line++ } ; /^{/ { total++; start = line } ; /^}/ {
> > len=line-start-3; if (len > 4) l++; if (len >= 10) k++; } ; END { print
> > total, l, l/total, k, k/total }' < include/net/tcp.h
> > 68 28 0.411765 20 0.294118
> >
> > 41% are over 4 lines, 29% are >= 10 lines.
>
> Take out the comments and whitespace lines, your script is
> too simplistic.
He should also remove these, which involve just syntactic casting to
please the compiler:
struct tcp_sock *tp = tcp_sk(sk);
struct inet_connection_sock *icsk = inet_csk(sk);
...and maybe some other similar ones. I'm sure that's going to make his
statistics even more questionable as is because we need tp all around.
But about his concerns, I spend couple of minutes in looking to it by
hand. These are likely to be a win:
tcp_set_state
tcp_prequeue
tcp_prequeue_init
tcp_openreq_init
...about rest I'm very unsure but there are some that probably are a
minor win as well.
tcp_dec_quickack_mode has only a single caller anyway so I'd doubt that
it's going to be significant, I thought moving it to .c earlier but
haven't just done that yet :-).
--
i.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
