From: Andi Kleen <[EMAIL PROTECTED]>
Date: Tue, 8 Jan 2008 03:05:29 +0100
> On Mon, Jan 07, 2008 at 05:54:58PM -0800, David Miller wrote:
> > I explicitly left them out.
> >
> > Most of them are abstractions of common 2 or 3 instruction
> > calculations, and thus should stay inline.
>
> Definitely not in tcp.h. It has quite a lot of very long functions, of
> which very few really need to be inline: (AFAIK the only one where
> it makes really sense is tcp_set_state due to constant evaluation;
> although I never quite understood why the callers just didn't
> call explicit functions to do these actions)
>
> % awk ' { line++ } ; /^{/ { start = line } ; /^}/ { n++; r += line-start-2;
> } ; END { print r/n }' < include/net/tcp.h
> 9.48889
>
> The average function length is 9 lines.
The vast majority of them are one, two, and three liners.
There are about 4 or 5 inlines in there are in fact large and perhaps
should be removed, and these puff up your average.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
