On Mon, Dec 17, 2007 at 08:26:01AM +0100, Jarek Poplawski wrote: > > Btw. #2: David Miller gave this example of ASSERT_RTNL use: > > ASSERT_RTNL(); > page = alloc_page(GFP_KERNEL); > > But isn't there a debugging duplication: it seems alloc_page() is used > in so many places and this check for GFP is/should_be there already?
On some paths this may be buried a conditional. Also if you replace it with a mutex_is_locked without the may_sleep it won't catch the case that started all this, namely the promiscuous path. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
