On Wed, 24 Feb 2021 02:13:05 +0000 Joakim Zhang wrote: > > > The aim is to enable clocks when it needs, others keep clocks disabled. > > > > Understood. Please double check ethtool callbacks work fine. People often > > forget about those when disabling clocks in .close. > > Hi Jakub, > > If NIC is open then clocks are always enabled, so all ethtool > callbacks should be okay. > > Could you point me which ethtool callbacks could be invoked when NIC > is closed? I'm not very familiar with ethtool use case. Thanks.
Well, all of them - ethtool does not check if the device is open. User can access and configure the device when it's closed. Often the callbacks access only driver data, but it's implementation specific so you'll need to validate the callbacks stmmac implements.
