> -----Original Message----- > From: Jakub Kicinski <k...@kernel.org> > Sent: 2021年2月24日 0:46 > To: Joakim Zhang <qiangqing.zh...@nxp.com> > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; netdev@vger.kernel.org; > dl-linux-imx <linux-...@nxp.com> > Subject: Re: [PATCH V1 net-next 1/3] net: stmmac: add clocks management for > gmac driver > > On Tue, 23 Feb 2021 18:48:16 +0800 Joakim Zhang wrote: > > +static int stmmac_bus_clks_enable(struct stmmac_priv *priv, bool > > +enabled) > > nit: my personal preference is to not call functions .._enable() and then make > them have a parameter saying if it's enable or disable. > Call the function .._config() or .._set() or such.
OK, thanks, will improve it. Best Regards, Joakim Zhang
