Hi Andrew, On 6/19/20 1:13 AM, Andrew Lunn wrote: > >> MAINTAINERS | 7 + >> drivers/net/phy/Kconfig | 6 + >> drivers/net/phy/Makefile | 1 + >> drivers/net/phy/mdio-lynx-pcs.c | 358 ++++++++++++++++++++++++++++++++ >> include/linux/mdio-lynx-pcs.h | 43 ++++ >> 5 files changed, 415 insertions(+) >> create mode 100644 drivers/net/phy/mdio-lynx-pcs.c >> create mode 100644 include/linux/mdio-lynx-pcs.h > > Hi Ioana > > We should think about naming convention here. > > All MDIO bus driver, MDIO multiplexors etc use mdio- as a prefix. > > This is not a bus driver, so i don't think it should use the mdio- > prefix. How about pcs-lynx.c? > > In terms of Kconfig, MDIO_ prefix is used for MDIO bus drivers etc. I > don't think it is appropriate here. How about PCS_LYNX? I don't think > any other subsystem is using PCS_ as a prefix. > >> --- a/drivers/net/phy/Kconfig >> +++ b/drivers/net/phy/Kconfig >> @@ -235,6 +235,12 @@ config MDIO_XPCS >> This module provides helper functions for Synopsys DesignWare XPCS >> controllers. >> >> +config MDIO_LYNX_PCS >> + bool >> + help >> + This module provides helper functions for Lynx PCS enablement >> + representing the PCS as an MDIO device. >> + >> endif >> endif > > Maybe add this at the end, and add a > > comment "PCS device drivers" > > before it? I'm assuming with time we will have more of these drivers. > > Andrew >
This driver faithfully follows the model of drivers/net/phy/mdio-xpcs.c. Should we rename that as well? Thanks, -Vladimir
