> Subject: Re: [PATCH net-next 5/5] net: dsa: felix: use the Lynx PCS helpers > > On Thu, 18 Jun 2020 15:08:37 +0300 Ioana Ciornei wrote: > > Use the helper functions introduced by the newly added Lynx PCS MDIO > > module. > > > > Instead of representing the PCS as a phy_device, a mdio_device > > structure will be passed to the Lynx module which is now actually > > implementing all the PCS configuration and status reporting. > > > > All code previously used for PCS momnitoring and runtime configuration > > is removed and replaced will calls to the Lynx PCS operations. > > > > Tested on the following SERDES protocols of LS1028A: 0x7777 > > (2500Base-X), 0x85bb (QSGMII), 0x9999 (SGMII) and 0x13bb (USXGMII). > > > > Signed-off-by: Ioana Ciornei <ioana.cior...@nxp.com> > > Reviewed-by: Vladimir Oltean <vladimir.olt...@nxp.com> > > Tested-by: Vladimir Oltean <vladimir.olt...@nxp.com> > > Hm, this does not build with allmodconfig. > > drivers/net/phy/mdio-lynx-pcs.o: In function `lynx_pcs_link_up': > mdio-lynx-pcs.c:(.text+0x115): undefined reference to `mdiobus_modify' > mdio-lynx-pcs.c:(.text+0x1a3): undefined reference to `mdiobus_write' > drivers/net/phy/mdio-lynx-pcs.o: In function `lynx_pcs_config': > mdio-lynx-pcs.c:(.text+0x33a): undefined reference to `mdiobus_write' > mdio-lynx-pcs.c:(.text+0x371): undefined reference to `mdiobus_modify' > mdio-lynx-pcs.c:(.text+0x384): undefined reference to > `phylink_mii_c22_pcs_config' > mdio-lynx-pcs.c:(.text+0x3e4): undefined reference to `mdiobus_write' > mdio-lynx-pcs.c:(.text+0x40d): undefined reference to `mdiobus_write' > mdio-lynx-pcs.c:(.text+0x422): undefined reference to `mdiobus_write' > drivers/net/phy/mdio-lynx-pcs.o: In function > `lynx_pcs_get_state_usxgmii.isra.0': > mdio-lynx-pcs.c:(.text+0x457): undefined reference to `mdiobus_read' > mdio-lynx-pcs.c:(.text+0x4f1): undefined reference to `mdiobus_read' > drivers/net/phy/mdio-lynx-pcs.o: In function `lynx_pcs_get_state': > mdio-lynx-pcs.c:(.text+0x650): undefined reference to > `phylink_mii_c22_pcs_get_state' > mdio-lynx-pcs.c:(.text+0x6fb): undefined reference to `phy_duplex_to_str' > mdio-lynx-pcs.c:(.text+0x711): undefined reference to `phy_speed_to_str' > mdio-lynx-pcs.c:(.text+0x7c0): undefined reference to `mdiobus_read' > mdio-lynx-pcs.c:(.text+0x7d4): undefined reference to `mdiobus_read' > drivers/net/phy/mdio-lynx-pcs.o: In function `lynx_pcs_an_restart': > mdio-lynx-pcs.c:(.text+0x954): undefined reference to `mdiobus_write' > mdio-lynx-pcs.c:(.text+0x978): undefined reference to > `phylink_mii_c22_pcs_an_restart' > make[1]: *** [vmlinux] Error 1 > make: *** [__sub-make] Error 2
Hmm, it seems that making the Kconfig just bool instead of tristate is the problem. Thank, Ioana
