On Mon, 26 Aug 2019 19:31:25 +0200, Marek Behun <marek.be...@nic.cz> wrote: > On Mon, 26 Aug 2019 17:38:30 +0200 > Andrew Lunn <and...@lunn.ch> wrote: > > > > +static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int > > > port, > > > + phy_interface_t mode, bool allow_over_2500, > > > + bool make_cmode_writable) > > > > I don't like these two parameters. The caller of this function can do > > the check for allow_over_2500 and error out before calling this. > > > > Is make_cmode_writable something that could be done once at probe and > > then forgotten about? Or is it needed before every write? At least > > move it into the specific port_set_cmode() that requires it. > > > > Thanks > > Andrew > > Btw those two additional parameters were modeled as in > static int mv88e6xxx_port_set_speed(struct mv88e6xxx_chip *chip, > int port, int speed, bool alt_bit, > bool force_bit);
"AltSpeed" and "ForceSpeed" are two bits found in the MAC Control Register of certain switch models, which can be set by this private helper. I don't think that is the case for "allow_over_2500" and "make_cmode_writable".
