> +static int mv88e6xxx_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
> + phy_interface_t mode, bool allow_over_2500,
> + bool make_cmode_writable)
I don't like these two parameters. The caller of this function can do
the check for allow_over_2500 and error out before calling this.
Is make_cmode_writable something that could be done once at probe and
then forgotten about? Or is it needed before every write? At least
move it into the specific port_set_cmode() that requires it.
Thanks
Andrew
